Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pre-compile visitable classes regex pattern (#17280) (CP: 24.1) #17281

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Pre compiles the regex pattern to improve build frontend performance
during the bytecode scan and collection of reachable classes.
Also adds some package exclusions for well knonw libraries that should
not be visited.

Part of #17234
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) July 25, 2023 07:45
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Test Results

   996 files  ±0     996 suites  ±0   1h 3m 36s ⏱️ +3s
6 319 tests ±0  6 278 ✔️ ±0  41 💤 ±0  0 ±0 
6 572 runs  ±0  6 524 ✔️ ±0  48 💤 ±0  0 ±0 

Results for commit ab5e283. ± Comparison against base commit 199b5e1.

@vaadin-bot vaadin-bot merged commit 45f33ac into 24.1 Jul 25, 2023
@vaadin-bot vaadin-bot deleted the cherry-pick-17280-to-24.1-1690270616374 branch July 25, 2023 08:01
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants