fix: prevent dev-tools connection to downgrade to streaming transport #18447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PushHandler expects that dev-tools connection to always use websocket transport. However, in case of client reconnection, atmosphere after a couple of attempts downgrades the transport to 'streaming', causing PushHandler to treat the connection as a Flow UI Push connection. This change set 'websocket' also as atmospehere fallback transport, so all reconnection attempts will use the expected transport. Fixes #18398
|
tepi
approved these changes
Jan 15, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
…#18447) PushHandler expects that dev-tools connection to always use websocket transport. However, in case of client reconnection, atmosphere after a couple of attempts downgrades the transport to 'streaming', causing PushHandler to treat the connection as a Flow UI Push connection. This change set 'websocket' also as atmospehere fallback transport, so all reconnection attempts will use the expected transport. Fixes #18398
vaadin-bot
added a commit
that referenced
this pull request
Jan 15, 2024
…#18447) (#18460) PushHandler expects that dev-tools connection to always use websocket transport. However, in case of client reconnection, atmosphere after a couple of attempts downgrades the transport to 'streaming', causing PushHandler to treat the connection as a Flow UI Push connection. This change set 'websocket' also as atmospehere fallback transport, so all reconnection attempts will use the expected transport. Fixes #18398 Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PushHandler expects that dev-tools connection to always use websocket transport. However, in case of client reconnection, atmosphere after a couple of attempts downgrades the transport to 'streaming', causing PushHandler to treat the connection as a Flow UI Push connection.
This change set 'websocket' also as atmospehere fallback transport, so all reconnection attempts will use the expected transport.
Fixes #18398
Type of change
Checklist
Additional for
Featuretype of change