-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add raw html table and related components #18553
Conversation
7cfc07c
to
128289c
Compare
Before Flow team starts making the review, I'd like to ping @rolfsmeds and @yuriy-fix to ask if they have immediate complains against this feature in general, e.g. naming, design or the whole idea about having this component on Flow side. |
Not sure if I'm getting something wrong but seems to me this patch does not really provide any added value in terms of convenience APIs and testing facilities. Only convenience API I could find is adding some components to here and there within the table or its sub-components. For example, comparing this to an add-on that was mentioned in the linked issue: Also, the testbench elements for Table and its parts are all empty. I have a hard time understanding what exactly is the value this patch brings as such? Saves you from typing the tag names when creating the elements? |
I focused on just adding bare bones components. I did not check the add-on and only based the components on other already existing html flow components. Since no API requirements or specifications were given in the issue (which I found only after I was done coding what is now in the PR) I submitted it as is. I thought of adding a few convenience methods, but decided against it. |
I don't have any objections to proceeding with this contribution. My only suggestion would be to opt for Regarding the component name |
I've added a bunch of methods to match most of the features provided in the add-on. I still need to write tests for those so once I'm done (next CF) I will change it back from draft. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code logic seems sound and I could not find any discrepancies.
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.5.0. |
Description
Add component for
<table>
element and related components:<caption>
<thead>
<tbody>
<tfoot>
<tr>
<th>
<td>
Fixes #15475