Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward with optional callback #19959

Merged
merged 7 commits into from
Sep 18, 2024
Merged

fix: forward with optional callback #19959

merged 7 commits into from
Sep 18, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Sep 16, 2024

Fixes #19794
Fixes #19822

Also fixes #19813 in a more coherent way. Relevant test is com.vaadin.flow.uitest.ui.PreserveOnRefreshForwardingIT

@tepi tepi marked this pull request as draft September 16, 2024 13:38
Copy link

github-actions bot commented Sep 16, 2024

Test Results

1 137 files  + 2  1 137 suites  +2   1h 25m 27s ⏱️ - 7m 28s
7 397 tests + 4  7 347 ✅ + 4  50 💤 ±0  0 ❌ ±0 
7 757 runs  +33  7 697 ✅ +33  60 💤 ±0  0 ❌ ±0 

Results for commit 73753ab. ± Comparison against base commit c615be5.

♻️ This comment has been updated with latest results.

@tepi tepi marked this pull request as ready for review September 17, 2024 10:41
@tepi tepi changed the title fix: forwarding without callback fix: forward with optional callback Sep 17, 2024
@tepi tepi marked this pull request as draft September 18, 2024 06:17
@tepi tepi marked this pull request as ready for review September 18, 2024 10:06
Copy link

sonarcloud bot commented Sep 18, 2024

@tepi tepi merged commit 62cae89 into main Sep 18, 2024
26 of 30 checks passed
@tepi tepi deleted the fix/router-forward-issue branch September 18, 2024 11:14
@vaadin-bot
Copy link
Collaborator

Hi @tepi and @tepi, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 62cae89
error: could not apply 62cae89... fix: forward with optional callback (#19959)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

tepi added a commit that referenced this pull request Sep 18, 2024
* fix: forwarding with optional callback
caalador pushed a commit that referenced this pull request Sep 18, 2024
Fixes #19794
Fixes #19822

Also fixes #19813 in a more coherent way. Relevant test is com.vaadin.flow.uitest.ui.PreserveOnRefreshForwardingIT
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment