Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close overlay drawer on click (#19984) (CP: 24.4) #20016

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* fix: close overlay drawer on click

Close the overlay drawer
even when clicking on
same link and no actual
navigation happens.

Fixes #19823

* reset fromAnchor for navigation

This in case the flag has
for some reason not been
reset after a click.
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) September 20, 2024 13:31
Copy link

sonarcloud bot commented Sep 20, 2024

Copy link

github-actions bot commented Sep 20, 2024

Test Results

1 111 files  +  516  1 111 suites  +516   1h 7m 47s ⏱️ + 13m 25s
7 058 tests +6 045  7 009 ✅ +6 031  49 💤 +14  0 ❌ ±0 
7 402 runs  +6 035  7 341 ✅ +6 021  61 💤 +14  0 ❌ ±0 

Results for commit 4516279. ± Comparison against base commit c6a147d.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot merged commit 7734d3d into 24.4 Sep 20, 2024
26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-19984-to-24.4-1726838768658 branch September 20, 2024 14:19
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants