Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update title after navigation #20047

Merged
merged 4 commits into from
Sep 26, 2024
Merged

fix: update title after navigation #20047

merged 4 commits into from
Sep 26, 2024

Conversation

caalador
Copy link
Contributor

Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868

Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868
tepi
tepi previously approved these changes Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Test Results

1 137 files  ±0  1 137 suites  ±0   1h 13m 58s ⏱️ + 4m 2s
7 399 tests ±0  7 349 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 760 runs   - 7  7 700 ✅  - 7  60 💤 ±0  0 ❌ ±0 

Results for commit 87a54ae. ± Comparison against base commit 36597dd.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Sep 25, 2024

@caalador caalador merged commit ad76611 into main Sep 26, 2024
26 checks passed
@caalador caalador deleted the issues/19868-wrong-title branch September 26, 2024 07:16
vaadin-bot pushed a commit that referenced this pull request Sep 26, 2024
Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868
vaadin-bot pushed a commit that referenced this pull request Sep 26, 2024
Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868
vaadin-bot added a commit that referenced this pull request Sep 26, 2024
Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Sep 26, 2024
* fix: update title after navigation (#20047)

Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868

* fix test mock

---------

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: Mikael Grankvist <mgrankvi@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong Tab Titles using History
3 participants