-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation reorganization #2381
Conversation
# Conflicts: # flow-documentation/Overview.asciidoc
Reviewed 76 of 99 files at r1, 5 of 5 files at r2. flow-documentation/Overview.asciidoc, line 32 at r2 (raw file):
This file is not in Hi @hezamu , thanks for the restructure idea. Currently it fails, pointing out a number of mistakes. flow-documentation/application-structure/tutorial-importing.asciidoc, line 3 at r2 (raw file):
This is listed as #3 in Overview.asciidoc, is it ok? flow-documentation/application-structure/tutorial-ways-of-importing.asciidoc, line 1 at r2 (raw file):
No header here? flow-documentation/element-api/tutorial-user-input.asciidoc, line 2 at r2 (raw file):
Typo. Comments from Reviewable |
Review status: 41 of 50 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed. flow-documentation/Overview.asciidoc, line 62 at r2 (raw file):
I cannot find the file at all in this commit. flow-documentation/Overview.asciidoc, line 85 at r2 (raw file):
There are 2 more files in the flow-documentation/application-structure/tutorial-bootstrap.asciidoc, line 3 at r2 (raw file):
This has the same order as flow-documentation/routing/tutorial-routing-annotation.asciidoc, line 3 at r2 (raw file):
This is listed as #1 in Overview, is it ok? At least 2 more from the same section has the same thing with their order number. Comments from Reviewable |
Reviewed 18 of 99 files at r1. Comments from Reviewable |
# Conflicts: # flow-documentation/Overview.asciidoc
Reviewed 12 of 99 files at r1, 99 of 99 files at r3. Comments from Reviewable |
Review status: all files reviewed at latest revision, 7 unresolved discussions. flow-documentation/Overview.asciidoc, line 85 at r2 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Now only one remains: Comments from Reviewable |
Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed. flow-documentation/Overview.asciidoc, line 85 at r2 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Apparently he preferred to move this one under misc instead of the application-structure, because it is an advanced topic. But only Muurimaa knows. Comments from Reviewable |
flow-documentation/Overview.asciidoc, line 85 at r2 (raw file): Previously, gilberto-torrezan (Gilberto Torrezan) wrote…
I think this was one of the files that wasn't referred to in overview, so I just picked misc. Please move it to a correct location. Comments from Reviewable |
flow-documentation/Overview.asciidoc, line 32 at r2 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
@gilberto-torrezan fixed this already. Comments from Reviewable |
flow-documentation/application-structure/tutorial-bootstrap.asciidoc, line 3 at r2 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Yes, since that file was moved to application-structure/. You guys know better than me what is the correct order for these articles. Comments from Reviewable |
flow-documentation/application-structure/tutorial-importing.asciidoc, line 3 at r2 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
See #2401 Comments from Reviewable |
Fixed ordering to match overview in #2402. Should be good to go after this? |
Review status: 121 of 134 files reviewed at latest revision, 2 unresolved discussions. flow-documentation/element-api/tutorial-user-input.asciidoc, line 2 at r2 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Done. flow-documentation/routing/tutorial-routing-annotation.asciidoc, line 3 at r2 (raw file): Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Done. Comments from Reviewable |
Reviewed 11 of 99 files at r1, 2 of 99 files at r3, 2 of 2 files at r4, 11 of 11 files at r5, 1 of 1 files at r6. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Moved docs to subfolders, added article headers used by the docs site builder script.
This change is