Register resource immediately if HttpService is available

[denis-anisimov]

This change is 

[bogdanudrescu]

Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)

---

flow-osgi/src/main/java/com/vaadin/flow/osgi/support/VaadinResourceTrackerComponent.java, line 193 at r1 (raw file):

                resource.getPath(), bundle);
        resourceToRegistration.put(serviceId, registration);
        if (httpService != null) {

Is there any chance that activate() is invoked after registerResource which will register the resource twice?

Or concurrently? I see there is no lock on individual resource register/unregister, but only on activate/deactivate.

(just asking, not blocking)

[denis-anisimov]

Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @bogdanudrescu and @denis-anisimov)

---

flow-osgi/src/main/java/com/vaadin/flow/osgi/support/VaadinResourceTrackerComponent.java, line 193 at r1 (raw file):

Previously, bogdanudrescu (Bogdan Udrescu) wrote…

Is there any chance that activate() is invoked after registerResource which will register the resource twice?

Or concurrently? I see there is no lock on individual resource register/unregister, but only on activate/deactivate.

(just asking, not blocking)

There is a chance.
There is no chance that httpService is not null if activate is not called yet.
The component won't be activated until httpService gets its not null value.
So if httpService is not null then activate has been already called.

Concurrency is handled by the instances: both resourceToRegistration and contributorToRegistrations are instantiated as synchronized maps .

So every single method call is thread safe.
The explicit synchronization is done when there is a need to modify maps atomically (several actions needs to be executed atomically).
But in fact this is out of the scope of this PR since I didn't introduce any additional map modification in the PR. The new code only does something with http service instance.

[vaadin-bot]

Replace the type specification in this constructor call with the diamond operator ("<>").

[vaadin-bot]

SonarQube analysis reported 2 issues

• 1 major
• 1 minor

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. VaadinResourceTrackerComponent.java#L159: Remove this unused method parameter "service".

[denis-anisimov]

Superseded by #5081