Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page.open() / Page.setLocation() functionality added #5130

Closed
wants to merge 2 commits into from
Closed

Page.open() / Page.setLocation() functionality added #5130

wants to merge 2 commits into from

Conversation

Lozadaa
Copy link

@Lozadaa Lozadaa commented Feb 25, 2019

fix issue #4869


This change is Reviewable

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Richard Lozada seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Lozadaa Lozadaa closed this Feb 25, 2019
@heruan
Copy link
Member

heruan commented Feb 25, 2019

@Lozadaa please stop creating the same PR over and over: just open a single one, sign the CLA and wait for a Vaadin member to give you feedback.

@Lozadaa Lozadaa reopened this Feb 25, 2019
@Lozadaa
Copy link
Author

Lozadaa commented Feb 25, 2019

@Lozadaa please stop creating the same PR over and over: just open a single one, sign the CLA and wait for a Vaadin member to give you feedback.

@heruan Sorry, i'll open this PR. Thx for you reply.

@Lozadaa Lozadaa closed this Feb 25, 2019
@Lozadaa Lozadaa reopened this Feb 25, 2019
@Lozadaa
Copy link
Author

Lozadaa commented Feb 25, 2019

Reopen PR fixing sonarqube issues

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Page.java#L74: Call "Optional#isPresent()" before accessing the value. rule
  2. MAJOR Page.java#L88: Call "Optional#isPresent()" before accessing the value. rule
  3. MAJOR Page.java#L426: Define and throw a dedicated exception instead of using a generic one. rule

@Lozadaa
Copy link
Author

Lozadaa commented Feb 25, 2019

commits still waiting for CLA but i was sign license.

@heruan
Copy link
Member

heruan commented Feb 26, 2019

@Lozadaa, pay attention to what the CLA assistant is telling you:

Richard Lozada seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

You committed using rlozada@bbr.cl but your GitHub e-mail address is richardalozada@hotmail.com so the commits might not be yours; add rlozada@bbr.cl to your GitHub profile or commit again as richardalozada@hotmail.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants