Revert squash, bring in changes from master #5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db77b37.
* Document the fact that a component with a parent will be added to a new parent and removed from the previous one.
* Add some configuration for surefire plugin Due to issues with tests run under Windows 10 we need to add the trimStackTrace and reuseForks configurations also to the surefire plugin * Also update the surefire and failsafe plugins.
Fix tests do that they "work" with windows.
denis-anisimov
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Reviewed 1 of 2 files at r6.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
denis-anisimov
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, 1 of 1 LGTMs obtained
This was referenced Jan 13, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR can not be squashed as it contains cherrypicks from master.
This change is