1.4 cherry picks #5949
1.4 cherry picks #5949
Conversation
Reworded to not imply that the component is only notified at the point in time when it gets attached.
(cherry picked from commit 3767d00)
Binder#bind() needs to have a setter as well. (cherry picked from commit bd19605)
(cherry picked from commit f1002c3)
(cherry picked from commit bf03d35)
* Remove non thrown exception. * update browser version * Disable failing shortcuts. (cherry picked from commit d8e7ea4)
(cherry picked from commit f1c97a0)
Remove unused code for loading a widgetset. (cherry picked from commit 7542a48)
(cherry picked from commit 1ec0402)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 2 of 3 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, 2 of 2 files at r10.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
| @@ -262,9 +262,6 @@ protected void service(HttpServletRequest request, | |||
| * @exception IOException | |||
| * if an input or output error occurs while the servlet is | |||
| * handling the HTTP request | |||
| * | |||
| * @exception ServletException | |||
| * if the HTTP request cannot be handled | |||
| */ | |||
| protected boolean serveStaticOrWebJarRequest(HttpServletRequest request, | |||
| HttpServletResponse response) throws ServletException, IOException { | |||
There was a problem hiding this comment.
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @ujoni)
There was a problem hiding this comment.
Dismissed @vaadin-bot from a discussion.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
I am not super-sure about the version bumps nor the removed code in
BootstrapHandler.js.These are PRs I skipped (out of the ones that looked like they should be cherried):
This change is