Show a warning when @HtmlImport is used in npm mode #6417
Conversation
There was a problem hiding this comment.
I see that Flow tests did not bat an eye when you changed the behavior regarding @HtmlImport annotation, which implies that there is no test which verified that those annotations get converted into @JsModule annotations when those are not present.
Since we are only logging, I am not sure how we'd test for that in a sensible fashion. :\
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
There was a problem hiding this comment.
According to my observation, the conversion of @HtmlImport into @JsModule doesn't work and since it was a temporary feature, we'd better remove the related code.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained (waiting on @ujoni)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
mehdi-vaadin
changed the title
Fix #6401
This change is