Skip to content

Commit

Permalink
Added missing @SInCE and javadocs
Browse files Browse the repository at this point in the history
Change-Id: I4241217a21b60b877a2213344607d112a14ff7d5
  • Loading branch information
makoivis committed Nov 3, 2014
1 parent 953881a commit 6143c8b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ protected static int indexOfIgnoringQuoted(String str, char find) {
/**
* Checks if path refers to vaadin UI element com.vaadin.ui.UI.
*
* @since 7.3.4
* @param path
* to vaadin element
* @return true if path refers to UI element, false otherwise
Expand All @@ -93,6 +94,7 @@ public static boolean isUIElement(String path) {
* Checks if path refers to vaadin Notification element
* com.vaadin.ui.Notification.
*
* @since 7.3.4
* @param path
* to vaadin element
* @return true if path refers to Notification element, false otherwise
Expand Down
11 changes: 11 additions & 0 deletions client/src/com/vaadin/client/ui/VSlider.java
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,11 @@ public void setValue(Double value, boolean fireEvents) {
}
}

/**
* Returns the feedback popup if subPart is "popup" and null otherwise.
*
* @since 7.3.4
*/
@Override
public com.google.gwt.user.client.Element getSubPartElement(String subPart) {
if (subPart.equals("popup")) {
Expand All @@ -664,6 +669,12 @@ public com.google.gwt.user.client.Element getSubPartElement(String subPart) {
return null;
}

/**
* Returns "popup" if any element is or has a child that corresponds to
* subElement.
*
* @since 7.3.4
*/
@Override
public String getSubPartName(com.google.gwt.user.client.Element subElement) {
if (feedbackPopup.getElement().isOrHasChild(subElement)) {
Expand Down

0 comments on commit 6143c8b

Please sign in to comment.