Optimize grid by avoiding redundant row refreshes

[hesara]

This change is 

[hesara]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

a discussion (no related file):
Do not submit before full test run completes.

---

Comments from Reviewable

[hesara]

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

---

a discussion (no related file):

Previously, hesara (Henri Sara) wrote…

Do not submit before full test run completes.

Test run completed with 2 new failures - one unrelated Calendar failure on IE11 (worked when retested locally) and one a sub-pixel rendering issue on IE11 (already seen in other branches as well).

---

Comments from Reviewable

[pleku]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

a discussion (no related file):
I think the following internal calls in Grid to refreshBody could be also maybe to use the scheduled version:

• setStylePrimaryName(String) - this is called on state updates from AbstractComopnentConnector, don't think it requires immediate refreshing of anything
• setSelectionModel(SelectionModel<T>) - changes the renderer so it is the same as the setRenderer` that was already done
• setSelectColumnRenderer(Renderer<Boolean>) - this is actually called by the setSelectionModel(..) above and could be set as scheduled for same reasons
• setRowStyleGenerator(RowStyleGenerator<T>) - called from GridConnector.init(), no need to do immediately refresh
• setCellStyleGenerator(CellStyleGenerator<T>) - called from GridConnector.init(), no need to do immediately refresh

---

Comments from Reviewable

[hesara]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

a discussion (no related file):

Previously, pleku (Pekka Hyvönen) wrote…

I think the following internal calls in Grid to refreshBody could be also maybe to use the scheduled version:

• setStylePrimaryName(String) - this is called on state updates from AbstractComopnentConnector, don't think it requires immediate refreshing of anything
• setSelectionModel(SelectionModel<T>) - changes the renderer so it is the same as the setRenderer` that was already done
• setSelectColumnRenderer(Renderer<Boolean>) - this is actually called by the setSelectionModel(..) above and could be set as scheduled for same reasons
• setRowStyleGenerator(RowStyleGenerator<T>) - called from GridConnector.init(), no need to do immediately refresh
• setCellStyleGenerator(CellStyleGenerator<T>) - called from GridConnector.init(), no need to do immediately refresh

Done, starting a full test build

---

Comments from Reviewable

[hesara]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

a discussion (no related file):

Previously, hesara (Henri Sara) wrote…

Done, starting a full test build

No new test failures in full build with these changes.

---

Comments from Reviewable

[pleku]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable