Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a helper to remap properties in filters and pageables #1870

Merged
merged 13 commits into from
Apr 9, 2024

Conversation

cromoteca
Copy link
Contributor

This class deals with the simplest cases of properties that change name or path in a DTO. It also supports a function to be applied each time a PropertyStringFilter is encountered, to allow for more sophisticated changes.

Closes #1865

@cromoteca cromoteca marked this pull request as draft December 8, 2023 07:05
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (5594c37) to head (b557b76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1870   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          67       67           
  Lines        4431     4431           
  Branches      630      630           
=======================================
  Hits         4225     4225           
  Misses        163      163           
  Partials       43       43           
Flag Coverage Δ
unittests 95.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cromoteca cromoteca marked this pull request as ready for review December 8, 2023 16:07
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@krissvaa krissvaa assigned krissvaa and unassigned krissvaa Jan 3, 2024
@cromoteca cromoteca requested a review from taefi April 9, 2024 12:31
cromoteca and others added 5 commits April 9, 2024 15:23
…ter/FilterTransformer.java

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
…ter/FilterTransformer.java

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
…ter/FilterTransformer.java

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
…ter/FilterTransformer.java

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cromoteca cromoteca requested a review from taefi April 9, 2024 13:29
@taefi taefi merged commit e37b6f7 into main Apr 9, 2024
15 checks passed
@taefi taefi deleted the feat/1865/remap-filter-properties branch April 9, 2024 13:51
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha21 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants