Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make init-app goal generate sources coherent with the project Hilla version #1901

Merged
merged 5 commits into from
Dec 20, 2023
Merged

fix: make init-app goal generate sources coherent with the project Hilla version #1901

merged 5 commits into from
Dec 20, 2023

Conversation

cromoteca
Copy link
Contributor

Fixes #1898

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5d5f57) 95.17% compared to head (7d539df) 95.17%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1901   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          52       52           
  Lines        3421     3421           
  Branches      501      501           
=======================================
  Hits         3256     3256           
  Misses        136      136           
  Partials       29       29
Flag Coverage Δ
unittests 95.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

knoobie
knoobie reviewed Dec 18, 2023
View reviewed changes
packages/java/plugin-base/src/main/java/dev/hilla/plugin/base/HillaAppInitUtility.java Outdated
@@ -15,15 +15,15 @@ public class HillaAppInitUtility {
private static final Logger LOGGER = LoggerFactory
.getLogger(HillaAppInitUtility.class);

private static final String REACT_SKELETON = "https://github.com/vaadin/skeleton-starter-hilla-react/archive/refs/heads/v2.1.zip";
private static final String REACT_SKELETON = "https://github.com/vaadin/skeleton-starter-hilla-react/archive/refs/heads/v2.5.zip";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to use e.g. Platform.getHillaVersion() so that the value doesn't have to be hardcoded?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have the version (or the branch name) as placeholder (...heads/v%s.zip or ...heads/%s.zip) and possibly have the version/branch as a parameter to scaffold(...) method, but probably it is not worth it.
Also using Platform.getHillaVersion() may not always work. I don't remember if during pre-releases there's already a related starter branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both of you, but this is not the good time to play with version-related stuff, see #1904 and #1905. Hopefully we'll include some better version tracking in files like this one when changing version handling.

@cromoteca @tarekoraby
Update packages/java/plugin-base/src/main/java/dev/hilla/plugin/base/…
5d365df 
…HillaAppInitUtility.java

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
@cromoteca cromoteca requested a review from taefi December 20, 2023 10:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cromoteca cromoteca merged commit 054510f into main Dec 20, 2023
15 checks passed
@cromoteca cromoteca deleted the fix/1898/Make-init-app-goal-generate-sources-coherent-with-the-project-Hilla-version branch December 20, 2023 19:14
vaadin-bot pushed a commit that referenced this pull request Dec 20, 2023
@cromoteca @tarekoraby @vaadin-bot
fix: make init-app goal generate sources coherent with the project Hi…
c436493 
…lla version (#1901)

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
sissbruecker pushed a commit that referenced this pull request Dec 21, 2023
@vaadin-bot @cromoteca @tarekoraby
fix: make init-app goal generate sources coherent with the project Hi…
b0f9946 
…lla version (#1901) (CP: 2.5) (#1918)

fix: make init-app goal generate sources coherent with the project Hilla version (#1901)

Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarekoraby tarekoraby tarekoraby left review comments

@mcollovati mcollovati mcollovati left review comments

@knoobie knoobie knoobie left review comments

@taefi taefi taefi approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.5 prerelease version for Hilla 24.4.0 Released with Hilla 24.4.0.alpha1 target/2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make init-app goal generate sources coherent with the project Hilla version
6 participants
@cromoteca @vaadin-bot @knoobie @mcollovati @tarekoraby @taefi