-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make NaN as default/empty number value in binder #1953
Conversation
6b4e02e
to
9d62191
Compare
008ce0d
to
b74fd78
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
- Coverage 95.33% 95.30% -0.03%
==========================================
Files 52 52
Lines 3495 3496 +1
Branches 526 527 +1
==========================================
Hits 3332 3332
Misses 129 129
- Partials 34 35 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ce1a521
to
145fe1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally. Touching a numeric field without typing a number shows a validation error, but I think that's the expected behavior.
Quality Gate failedFailed conditions 20.8% Duplication on New Code (required ≤ 3%) |
This ticket/PR has been released with Hilla 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version. |
Make NaN as default/empty number value in binder
After form the number fields are empty by default:
Fixes #1827