Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make NaN as default/empty number value in binder #1953

Merged
merged 9 commits into from
Jan 30, 2024

Conversation

krissvaa
Copy link
Contributor

Make NaN as default/empty number value in binder

After form the number fields are empty by default:
image

Fixes #1827

@krissvaa krissvaa marked this pull request as draft January 11, 2024 17:12
@krissvaa krissvaa force-pushed the feat/1827/default-number-nan branch 2 times, most recently from 008ce0d to b74fd78 Compare January 16, 2024 11:20
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cbb15d) 95.33% compared to head (2235fec) 95.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
- Coverage   95.33%   95.30%   -0.03%     
==========================================
  Files          52       52              
  Lines        3495     3496       +1     
  Branches      526      527       +1     
==========================================
  Hits         3332     3332              
  Misses        129      129              
- Partials       34       35       +1     
Flag Coverage Δ
unittests 95.30% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krissvaa krissvaa marked this pull request as ready for review January 26, 2024 17:27
Copy link
Contributor

@cromoteca cromoteca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally. Touching a numeric field without typing a number shows a validation error, but I think that's the expected behavior.

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

20.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@platosha platosha merged commit f288bcd into main Jan 30, 2024
13 of 15 checks passed
@platosha platosha deleted the feat/1827/default-number-nan branch January 30, 2024 10:36
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autocrud] Number fields in forms show 0 by default
4 participants