-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to amend Atmosphere configuration #1959
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 52 52
Lines 3479 3482 +3
Branches 522 524 +2
=======================================
+ Hits 3316 3319 +3
Misses 129 129
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Hi @cromoteca and @cromoteca, when i performed cherry-pick to this commit to 1.4, i have encountered the following issue. Can you take a look and pick it manually? |
Hi @cromoteca and @cromoteca, when i performed cherry-pick to this commit to 1.3, i have encountered the following issue. Can you take a look and pick it manually? |
feat: allow to amend Atmosphere configuration (#1959) Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
feat: allow to amend Atmosphere configuration (#1959) Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
feat: allow to amend Atmosphere configuration (#1959) Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
feat: allow to amend Atmosphere configuration (#1959) Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
This ticket/PR has been released with Hilla 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version. |
This PR allow users to create a custom
connect-client.js
file and pass an optional object containing any of theAtmosphere.Request
configuration parameters.Related to #1830.