Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to amend Atmosphere configuration #1959

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

cromoteca
Copy link
Contributor

This PR allow users to create a custom connect-client.js file and pass an optional object containing any of the Atmosphere.Request configuration parameters.

Related to #1830.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66e6de1) 95.31% compared to head (f0b9dcc) 95.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1959   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          52       52           
  Lines        3479     3482    +3     
  Branches      522      524    +2     
=======================================
+ Hits         3316     3319    +3     
  Misses        129      129           
  Partials       34       34           
Flag Coverage Δ
unittests 95.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cromoteca cromoteca merged commit 71cff2a into main Jan 18, 2024
15 checks passed
@cromoteca cromoteca deleted the feat/allow-atmosphere-configuration branch January 18, 2024 11:54
@vaadin-bot
Copy link
Collaborator

Hi @cromoteca and @cromoteca, when i performed cherry-pick to this commit to 1.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 71cff2a
error: could not apply 71cff2a... feat: allow to amend Atmosphere configuration (#1959)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @cromoteca and @cromoteca, when i performed cherry-pick to this commit to 1.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 71cff2a
error: could not apply 71cff2a... feat: allow to amend Atmosphere configuration (#1959)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

taefi pushed a commit that referenced this pull request Jan 24, 2024
feat: allow to amend Atmosphere configuration (#1959)

Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
taefi pushed a commit that referenced this pull request Jan 24, 2024
feat: allow to amend Atmosphere configuration (#1959)

Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
taefi pushed a commit that referenced this pull request Jan 24, 2024
feat: allow to amend Atmosphere configuration (#1959)

Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
taefi pushed a commit that referenced this pull request Jan 24, 2024
feat: allow to amend Atmosphere configuration (#1959)

Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
taefi pushed a commit that referenced this pull request Jan 24, 2024
… (CP: 1.3) (#1984)

feat: allow to amend Atmosphere configuration (#1959) (CP: 1.4) (#1983)

Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants