Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new attribute 'hiddenFields' to configure which fields shou… #2294

Merged

Conversation

rbrki07
Copy link
Contributor

@rbrki07 rbrki07 commented Apr 4, 2024

…ld hide in autoform

Description

Adding a new attribute hiddenFields for AutoForm component allowing to hide certain fields in the form. This feature tries to achive a kind of api parity between AutoGrid and AutoGrid, because #2279 introduced hiddenColumns to AutoGrid.

Fixes #2290

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@rbrki07 rbrki07 force-pushed the feature/new-auto-form-attribute-hidden-fields branch from 82e7126 to ff7ce63 Compare April 4, 2024 14:01
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (bdc401c) to head (379b70b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2294   +/-   ##
=======================================
  Coverage   93.78%   93.79%           
=======================================
  Files          66       66           
  Lines        1642     1644    +2     
  Branches      369      370    +1     
=======================================
+ Hits         1540     1542    +2     
  Misses         67       67           
  Partials       35       35           
Flag Coverage Δ
unittests 93.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbrki07 rbrki07 requested a review from cromoteca April 4, 2024 18:43
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cromoteca cromoteca merged commit b2c008c into vaadin:main Apr 5, 2024
15 checks passed
@rbrki07 rbrki07 deleted the feature/new-auto-form-attribute-hidden-fields branch April 5, 2024 07:34
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha21 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoform][dx] Provide a way for listing only the fields that should be hidden
3 participants