fix: [autogrid] ignore default object json renderer if columnOption path is set
#2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-type-object-if-custom-path-is-set
taefi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
- Coverage 95.17% 95.13% -0.05%
==========================================
Files 66 66
Lines 4499 4500 +1
Branches 644 645 +1
==========================================
- Hits 4282 4281 -1
- Misses 177 179 +2
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
taefi
reviewed
Apr 29, 2024
taefi
changed the title
path is set
taefi
changed the title
path is setpath is set
taefi
requested changes
Apr 30, 2024
…n-type-object-if-custom-path-is-set
…n-type-object-if-custom-path-is-set
|
taefi
approved these changes
May 2, 2024
rbrki07
deleted the
fix/autogrid-uses-default-renderer-for-column-type-object-if-custom-path-is-set
branch
|
This ticket/PR has been released with Hilla 24.4.0.beta2 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix that AutoGrid uses the build-in JSON renderer for a column of type
object, although a custompathis set for this column. Instead, it should use the default string renderer for the property target withpath.Fixes #2322
Type of change
Checklist