Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add resource pattern for file-routes.json (#2396) (CP: 24.4) #2446

Merged
merged 6 commits into from
May 21, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

rbrki07 and others added 5 commits May 20, 2024 14:05
* fix: add resource pattern for file-routes.json

* apply suggestions from taefi

* Register hints for META-INF/VAADIN/* and ClientViewConfig.class

* fix hints for deserializing file-routes properly

---------

Co-authored-by: Marcus Hellberg <marcus@vaadin.com>
Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
…915978' into cherry-pick-2396-to-24.4-1716213915978
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.4@25a3449). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.4    #2446   +/-   ##
=======================================
  Coverage        ?   95.09%           
=======================================
  Files           ?       66           
  Lines           ?     4510           
  Branches        ?      647           
=======================================
  Hits            ?     4289           
  Misses          ?      180           
  Partials        ?       41           
Flag Coverage Δ
unittests 95.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@platosha platosha enabled auto-merge (squash) May 21, 2024 13:15
@platosha platosha merged commit 143b29c into 24.4 May 21, 2024
15 checks passed
@platosha platosha deleted the cherry-pick-2396-to-24.4-1716213915978 branch May 21, 2024 13:28
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Hilla 24.4.0.beta4 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants