-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(file-router): tune server routes addition in case of variable routes presented #2448
Conversation
# Conflicts: # packages/ts/file-router/test/vite-plugin/collectRoutesFromFS.spec.ts
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
+ Coverage 95.13% 95.15% +0.02%
==========================================
Files 66 66
Lines 4501 4524 +23
Branches 646 649 +3
==========================================
+ Hits 4282 4305 +23
Misses 178 178
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Hi @Lodin and @ZheSun88, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
Fixes #2404.