Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(file-router): tune server routes addition in case of variable routes presented #2448

Merged
merged 14 commits into from
May 22, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented May 21, 2024

Fixes #2404.

@Lodin Lodin requested review from platosha and taefi May 21, 2024 08:35
@Lodin Lodin added the hilla Issues related to Hilla label May 21, 2024
@ZheSun88
Copy link
Contributor

  NX   Running target test:coverage for 16 projects failed

   Failed tasks:
   
   - @vaadin/hilla-file-router:test:coverage

@Lodin
Copy link
Contributor Author

Lodin commented May 21, 2024

@ZheSun88, yeah, it looks like there is some kind of a FS handling on different systems. I cannot reproduce that locally but @taefi managed to do it

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (2c32e67) to head (1d431c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2448      +/-   ##
==========================================
+ Coverage   95.13%   95.15%   +0.02%     
==========================================
  Files          66       66              
  Lines        4501     4524      +23     
  Branches      646      649       +3     
==========================================
+ Hits         4282     4305      +23     
  Misses        178      178              
  Partials       41       41              
Flag Coverage Δ
unittests 95.15% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ZheSun88 ZheSun88 enabled auto-merge (squash) May 22, 2024 09:38
@ZheSun88 ZheSun88 merged commit 78f4f92 into main May 22, 2024
15 checks passed
@ZheSun88 ZheSun88 deleted the fix/file/optional-route branch May 22, 2024 10:00
@vaadin-bot
Copy link
Collaborator

Hi @Lodin and @ZheSun88, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 78f4f92
error: could not apply 78f4f92... refactor(file-router): tune server routes addition in case of variable routes presented (#2448)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Lodin added a commit that referenced this pull request May 23, 2024
* forbid same names for sibling file and directory (#2443)
* tune server routes addition in case of variable routes presented (#2448)
Lodin added a commit that referenced this pull request May 23, 2024
…24.4) (#2457)

* refactor(file-router): forbid same names for sibling file and directory (#2443)
* refactor(file-router): tune server routes addition in case of variable routes presented (#2448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional route parameters are broken when using withFallback
6 participants