Skip to content

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Apr 1, 2025

Description

There is a following compilation warning after the 24.8.0-alpha4 bump:

[types]   Types of property 'part' are incompatible.
[types]     Type 'string | undefined' is not assignable to type 'DOMTokenList | undefined'.
[types]       Type 'string' is not assignable to type 'DOMTokenList'.

Looks like types for part were added in a recent PR: DefinitelyTyped/DefinitelyTyped#72230

And in lib.dom.d.ts there are following types:

get part(): DOMTokenList;
set part(value: string);

Let's add an explicit dev dependency to downgrade version for now.

Type of change

  • Internal change

@web-padawan web-padawan requested a review from sissbruecker April 1, 2025 09:54
@web-padawan web-padawan merged commit 305f984 into main Apr 1, 2025
2 checks passed
@web-padawan web-padawan deleted the chore/pin-types-react branch April 1, 2025 10:01
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 305f984
error: could not apply 305f984... chore: pin @types/react to avoid TS compilation warning (#308)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 305f984
error: could not apply 305f984... chore: pin @types/react to avoid TS compilation warning (#308)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants