-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow windows developers to work with this repo without hassle #5686
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi @bwajtr , this commit cannot be picked to 24.0 by this bot, can you take a look and pick it manually? |
This ticket/PR has been released with Vaadin 24.1.0.alpha2 and is also targeting the upcoming stable 24.1.0 version. |
Description
endOfLine
check in Prettier changed fromauto
toLF
in version 2.0.0. This is very inconvenient for Windows developers. Because when you installgit
on Winwows, you'll automatically havecore.autocrlf
set totrue
, which will basically change allLF
line endings toCRLF
line endings when you clone the repository. Git then ensures thatCRLF
is converted back toLF
on commit. However, because you haveCRLF
locally, Prettier checks fail. The solution to this is to not enforce line endings by Prettier, but actually, letgit
handle it automatically.auto
again, so Prettier ignores it.gitattributes
file, which enables git to handleCRLF
toLF
conversion for Windows developers automatically, regadless of their local settings ofcore.autocrlf
. Git makes sure, thanks to this file, that remote will always contain onlyLF
. Topic is explained here..idea
directory to .gitingore so IntelliJ Idea project files are ignored when you work with the repository in IdeaType of change
[x] Chore