Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uturn cases on not_thru edge connected to origin. #2272

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Conversation

dnesbitt61
Copy link
Member

@dnesbitt61 dnesbitt61 commented Mar 14, 2020

Fix Uturn cases when a not_thru edge is connected to the origin edge.
Add comments for new parameters.

Issue

fixes #2271

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@dnesbitt61 dnesbitt61 merged commit 9b30d3e into master Mar 24, 2020
@dnesbitt61 dnesbitt61 deleted the uturn_fix branch March 24, 2020 11:48
yuzheyan added a commit that referenced this pull request Mar 25, 2020
* master:
  additional data processing options  (#2285)
  Fix Uturn cases on not_thru edge connected to origin. (#2272)
  Interpolation bug fix (#2275)
yuzheyan added a commit that referenced this pull request Mar 25, 2020
* master:
  additional data processing options  (#2285)
  Fix Uturn cases on not_thru edge connected to origin. (#2272)
  Interpolation bug fix (#2275)
  Update intersection classes in osrm response to not label all ramps as motorway (#2279)
  More stop impact changes (#2282)
  Fixed verbal multi-cue logic (#2270)
  Re-write test/astar.cc to use gurka graph creation helpers rather than hard-coding edge creation/IDs
  Add gurka test framework to ease creation of test cases with ascii-maps
  Add helper functions so that we can perform actions without serializing if desired - this is to support testing of intermediate results.
  Make protobuf cleanup after tile building optional (on by default) so that tests can repeatedly call mjolnir::build_tile_set
  Downgrade some log messages to warnings - they are non-fatal behaviours, no error is actually emitted by the code.
  Reduce concurrency of lint debug build so that it doesn't hit OOM problems on CI
  Exact Reachability (ie v3) (#2243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bicycle Routing Uturns (not_thru culling issue)
2 participants