additional data processing options #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow_alt_name as a config option.
…config. Will be False for OSM.
gknisely
changed the title
dgearhart
reviewed
Mar 24, 2020
| @@ -65,6 +65,8 @@ struct graph_callback : public OSMPBF::Callback { | |||
| infer_internal_intersections_ = | |||
| pt.get<bool>("data_processing.infer_internal_intersections", true); | |||
| infer_turn_channels_ = pt.get<bool>("data_processing.infer_turn_channels", true); | |||
| use_direction_on_ways_ = pt.get<bool>("data_processing.use_direction_on_ways", false); | |||
There was a problem hiding this comment.
where does reclassify_links get set?
There was a problem hiding this comment.
valhalla/src/mjolnir/graphbuilder.cc
Line 1168 in 2fe491e
After i enabled this I noticed that I want to move and parser, builder, or enhancer flags to under the data_processing section in the config.
dgearhart
reviewed
Mar 24, 2020
| @@ -1030,6 +1037,74 @@ struct graph_callback : public OSMPBF::Callback { | |||
| } | |||
| } | |||
|
|
|||
| if (use_direction_on_ways_ && !ref.empty()) { | |||
There was a problem hiding this comment.
do we have any tests for the direction assignments?
dgearhart
reviewed
Mar 24, 2020
| 'use_admin_db': 'bool indicating whether or not to use the administrative database during the graph enhancer phase or use the admin keys from the pbf that are set on the way' | ||
| 'use_admin_db': 'bool indicating whether or not to use the administrative database during the graph enhancer phase or use the admin keys from the pbf that are set on the way', | ||
| 'use_direction_on_ways': 'bool indicating whether or not to process the direction key on the ways or utilize the guidance relation tags during the parsing phase', | ||
| 'allow_alt_name': 'bool indicating whether or not to process the alt_name key on the ways during the parsing phase' |
There was a problem hiding this comment.
in the future might want to use the name:<lg> for street signs with multiple languages
yuzheyan
added a commit
that referenced
this pull request
Mar 25, 2020
* master: additional data processing options (#2285) Fix Uturn cases on not_thru edge connected to origin. (#2272) Interpolation bug fix (#2275) Update intersection classes in osrm response to not label all ramps as motorway (#2279) More stop impact changes (#2282) Fixed verbal multi-cue logic (#2270) Re-write test/astar.cc to use gurka graph creation helpers rather than hard-coding edge creation/IDs Add gurka test framework to ease creation of test cases with ascii-maps Add helper functions so that we can perform actions without serializing if desired - this is to support testing of intermediate results. Make protobuf cleanup after tile building optional (on by default) so that tests can repeatedly call mjolnir::build_tile_set Downgrade some log messages to warnings - they are non-fatal behaviours, no error is actually emitted by the code. Reduce concurrency of lint debug build so that it doesn't hit OOM problems on CI Exact Reachability (ie v3) (#2243)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Added reclassify_links, use_direction_on_ways, and allow_alt_name as config options. If
use_direction_on_ways = truethen usedirectionandint_directionon the way to update the directional for therefandint_ref.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?