-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional data processing options #2285
Conversation
…llow_alt_name as a config option.
…config. Will be False for OSM.
@@ -65,6 +65,8 @@ struct graph_callback : public OSMPBF::Callback { | |||
infer_internal_intersections_ = | |||
pt.get<bool>("data_processing.infer_internal_intersections", true); | |||
infer_turn_channels_ = pt.get<bool>("data_processing.infer_turn_channels", true); | |||
use_direction_on_ways_ = pt.get<bool>("data_processing.use_direction_on_ways", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does reclassify_links
get set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valhalla/src/mjolnir/graphbuilder.cc
Line 1168 in 2fe491e
if (pt.get<bool>("mjolnir.reclassify_links", true)) { |
After i enabled this I noticed that I want to move and parser, builder, or enhancer flags to under the data_processing
section in the config.
@@ -1030,6 +1037,74 @@ struct graph_callback : public OSMPBF::Callback { | |||
} | |||
} | |||
|
|||
if (use_direction_on_ways_ && !ref.empty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any tests for the direction assignments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add some
'use_admin_db': 'bool indicating whether or not to use the administrative database during the graph enhancer phase or use the admin keys from the pbf that are set on the way' | ||
'use_admin_db': 'bool indicating whether or not to use the administrative database during the graph enhancer phase or use the admin keys from the pbf that are set on the way', | ||
'use_direction_on_ways': 'bool indicating whether or not to process the direction key on the ways or utilize the guidance relation tags during the parsing phase', | ||
'allow_alt_name': 'bool indicating whether or not to process the alt_name key on the ways during the parsing phase' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future might want to use the name:<lg>
for street signs with multiple languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
* master: additional data processing options (#2285) Fix Uturn cases on not_thru edge connected to origin. (#2272) Interpolation bug fix (#2275) Update intersection classes in osrm response to not label all ramps as motorway (#2279) More stop impact changes (#2282) Fixed verbal multi-cue logic (#2270) Re-write test/astar.cc to use gurka graph creation helpers rather than hard-coding edge creation/IDs Add gurka test framework to ease creation of test cases with ascii-maps Add helper functions so that we can perform actions without serializing if desired - this is to support testing of intermediate results. Make protobuf cleanup after tile building optional (on by default) so that tests can repeatedly call mjolnir::build_tile_set Downgrade some log messages to warnings - they are non-fatal behaviours, no error is actually emitted by the code. Reduce concurrency of lint debug build so that it doesn't hit OOM problems on CI Exact Reachability (ie v3) (#2243)
Issue
Added reclassify_links, use_direction_on_ways, and allow_alt_name as config options. If
use_direction_on_ways = true
then usedirection
andint_direction
on the way to update the directional for theref
andint_ref
.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?