-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More stop impact changes #2282
More stop impact changes #2282
Conversation
… vice versa. depends on driving side.
…sts even though a previous test may fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all about the testing - i think you said there weren't any negative impacts - if so
My only comment is that typically the right vs left driving side is handled in the Costing classes by having different cost penalties based on the turn type. Seems like this is adding this consideration also during data creation which in my opinion complicates things. |
* master: additional data processing options (#2285) Fix Uturn cases on not_thru edge connected to origin. (#2272) Interpolation bug fix (#2275) Update intersection classes in osrm response to not label all ramps as motorway (#2279) More stop impact changes (#2282) Fixed verbal multi-cue logic (#2270) Re-write test/astar.cc to use gurka graph creation helpers rather than hard-coding edge creation/IDs Add gurka test framework to ease creation of test cases with ascii-maps Add helper functions so that we can perform actions without serializing if desired - this is to support testing of intermediate results. Make protobuf cleanup after tile building optional (on by default) so that tests can repeatedly call mjolnir::build_tile_set Downgrade some log messages to warnings - they are non-fatal behaviours, no error is actually emitted by the code. Reduce concurrency of lint debug build so that it doesn't hit OOM problems on CI Exact Reachability (ie v3) (#2243)
Issue
Add to the stop impact when transitioning from higher to lower class road and we are not on a TC
or ramp. Also, penalize lefts when driving on the right and vice versa.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?
Results
Example 1: jughandle_routes # 13 - Before
Example 1: jughandle_routes # 13 - After
Example 2: Before
Example 2: After
Example 3: Using unmaintained track roads - Before
![image](https://user-images.githubusercontent.com/2676277/77115826-67f96600-6a05-11ea-81f2-92cefb4fe5e1.png)
Example 3: Avoiding unmaintained track roads - After
![image](https://user-images.githubusercontent.com/2676277/77115603-02a57500-6a05-11ea-94bd-cd632ccfab80.png)
Example 4: U-turn - Before
![image](https://user-images.githubusercontent.com/2676277/77117808-1d79e880-6a09-11ea-8581-aa2305412096.png)
Example 4: Avoids u-turn - After
![image](https://user-images.githubusercontent.com/2676277/77117862-3f736b00-6a09-11ea-8f72-9f7bc5c5e6ad.png)
Example 5: Complex starting route - Before
![image](https://user-images.githubusercontent.com/2676277/77118572-d7258900-6a0a-11ea-96e8-d4baa7e5cba6.png)
Example 5: Less complex staring route - After
![image](https://user-images.githubusercontent.com/2676277/77118602-f2909400-6a0a-11ea-9ab2-b5de5b174d6f.png)