More stop impact changes #2282
Merged
More stop impact changes #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vice versa. depends on driving side.
…sts even though a previous test may fail.
dgearhart
approved these changes
Mar 20, 2020
|
My only comment is that typically the right vs left driving side is handled in the Costing classes by having different cost penalties based on the turn type. Seems like this is adding this consideration also during data creation which in my opinion complicates things. |
yuzheyan
added a commit
that referenced
this pull request
Mar 25, 2020
* master: additional data processing options (#2285) Fix Uturn cases on not_thru edge connected to origin. (#2272) Interpolation bug fix (#2275) Update intersection classes in osrm response to not label all ramps as motorway (#2279) More stop impact changes (#2282) Fixed verbal multi-cue logic (#2270) Re-write test/astar.cc to use gurka graph creation helpers rather than hard-coding edge creation/IDs Add gurka test framework to ease creation of test cases with ascii-maps Add helper functions so that we can perform actions without serializing if desired - this is to support testing of intermediate results. Make protobuf cleanup after tile building optional (on by default) so that tests can repeatedly call mjolnir::build_tile_set Downgrade some log messages to warnings - they are non-fatal behaviours, no error is actually emitted by the code. Reduce concurrency of lint debug build so that it doesn't hit OOM problems on CI Exact Reachability (ie v3) (#2243)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Add to the stop impact when transitioning from higher to lower class road and we are not on a TC
or ramp. Also, penalize lefts when driving on the right and vice versa.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?
Results
Example 1: jughandle_routes # 13 - Before
Example 1: jughandle_routes # 13 - After
Example 2: Before
Example 2: After
Example 3: Using unmaintained track roads - Before
Example 3: Avoiding unmaintained track roads - After
Example 4: U-turn - Before
Example 4: Avoids u-turn - After
Example 5: Complex starting route - Before
Example 5: Less complex staring route - After
