Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed verbal multi-cue logic #2270

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Fixed verbal multi-cue logic #2270

merged 3 commits into from
Mar 11, 2020

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Mar 11, 2020

Added default_speed to trip proto to be used by multi cue logic
Added multi cue test
Refreshed other pinpoints as needed

Issue

Have verbal multi-cue logic use default speed for edges.

image

< BEFORE
< Drive north on Hartman Bridge Road, Pennsylvania 8 96 for 200 feet.
> AFTER
> Drive north on Hartman Bridge Road, Pennsylvania 8 96 for 200 feet. Then Turn left onto U.S. 30.

< BEFORE
< Turn left onto U.S. 30, Lincoln Highway East.
> AFTER
> Turn left onto U.S. 30, Lincoln Highway East. Then Turn right.

< BEFORE
< Turn right.
> AFTER
> Turn right. Then Adidas Outlet will be on the left.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Added multi cue test
Refreshed other pinpoints as needed
@dgearhart dgearhart self-assigned this Mar 11, 2020
@dgearhart dgearhart merged commit 31e8fc8 into master Mar 11, 2020
@dgearhart dgearhart deleted the multi_cue_fix branch March 11, 2020 15:30
yuzheyan added a commit that referenced this pull request Mar 25, 2020
* master:
  additional data processing options  (#2285)
  Fix Uturn cases on not_thru edge connected to origin. (#2272)
  Interpolation bug fix (#2275)
  Update intersection classes in osrm response to not label all ramps as motorway (#2279)
  More stop impact changes (#2282)
  Fixed verbal multi-cue logic (#2270)
  Re-write test/astar.cc to use gurka graph creation helpers rather than hard-coding edge creation/IDs
  Add gurka test framework to ease creation of test cases with ascii-maps
  Add helper functions so that we can perform actions without serializing if desired - this is to support testing of intermediate results.
  Make protobuf cleanup after tile building optional (on by default) so that tests can repeatedly call mjolnir::build_tile_set
  Downgrade some log messages to warnings - they are non-fatal behaviours, no error is actually emitted by the code.
  Reduce concurrency of lint debug build so that it doesn't hit OOM problems on CI
  Exact Reachability (ie v3) (#2243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants