-
Notifications
You must be signed in to change notification settings - Fork 8
feat: multicluster support #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
butler54
commented
Sep 17, 2025
- feat: allow the use of self-signed certificates with trustee
- chore: ansible linting
- chore: ansible docs
- fix: linting
- feat: add multicluster support
- fix: update global pattern
- fix: add cert manager operator back in
- fix: correct hub-to-spoke
#55 needs to be merged first then this needs to be rebased |
Signed-off-by: Chris Butler <chris.butler@redhat.com>
7e11018
to
ac803d1
Compare
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
@butler54 Deployed the pattern. Some comments based on my deployment
|
Okay so this is my fault - looks like we have two paths:
I'll take that on as it's a requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @butler54, I'm finally here.
Heads up, I tend to review commit-by-commit (old upstream habits die hard), so the large initial commit followed by chore commits was a bit annoying to navigate. Please, take it as a nit, feel free to ignore for this PR. Just thinking ahead to the helm repo split where smaller commits will help with more contributors.
playbook: ansible/init-data-gzipper.yaml | ||
verbosity: -vvv | ||
timeout: 3600 | ||
managedClusterGroups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an ACM user... but I was expecting an application list here as well.
|
||
if [ $SPOKE_EXIT_CODE -eq 0 ]; then | ||
echo "Spoke cluster (coco-spoke) kubeconfig: $(pwd)/openshift-install-spoke/auth/kubeconfig" | ||
echo "Both clusters deployed successfully!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should import spoke into ACM here? I was expecting something like:
oc apply -f - <<EOF
apiVersion: cluster.open-cluster-management.io/v1
kind: ManagedCluster
metadata:
name: coco-spoke
labels:
clusterGroup: untrusted-spoke
spec:
hubAcceptsClient: true
EOF
@@ -1,5 +1,3 @@ | |||
# Sandboxed policies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit could be squashed with ac803d1be8f411d1fe9e066598bec79d68239ed9
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
import json | ||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this one: ac803d1