ArgoCD Secret handling #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to change how makefiles are handled in the pattern directories.
Since common should not know which namespaces the secrets need to be injected into, and something the patterns must know, trust them to do so.
This means that instead of Makefile being a symlink in the pattern directory, it becomes a "real" makefile, which must then delegate tasks to the Makefile in common (and may add its own tasks, or customize them, as appropriate).
This adds a generic task to inject the argocd admin password into an arbitrary namespace, after determining that the new namespace is available and that the gitops (argocd server) has generated the secret.