Renaming main files and creating modules for the med-diagnosis pattern #310
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abhatt-rh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abhatt-rh
force-pushed
the
1193-modular
branch
from
db1ef8a to
b1a2505
Compare
abhatt-rh
force-pushed
the
1193-modular
branch
2 times, most recently
from
aa8cb9b to
8ae400e
Compare
abhatt-rh
changed the title
abhatt-rh
force-pushed
the
1193-modular
branch
from
8ae400e to
b0b31c0
Compare
|
This is an automated message: You can preview this docs PR at http://310.docs-pr.validatedpatterns.io |
abhatt-rh
force-pushed
the
1193-modular
branch
2 times, most recently
from
404f63e to
f6bb3d0
Compare
|
Hi @danmacpherson PTAL. Thanks! |
There was a problem hiding this comment.
Hi Avani,
A few minor suggestions, and a few other things:
- I couldn't seem to comment on the troubleshooting section since it looks like it's largely unchanged and so I can't leave feedback on any diff. This might need to be rechecked as I noticed a few things that needed some style and consistency.
- Likewise I think there's something odd with the title levels in the Troubleshooting section.
- There are a fair few videos/animations in this content. I wonder if we can include these things in our enterprise docs. Something to check out.
| $ git push origin my-branch | ||
| ---- | ||
|
|
||
| . To deploy the pattern, you can use the link:/infrastructure/using-validated-pattern-operator/[{validated-patterns-op}]. If you use the Operator to deploy the pattern, skip to the _Verification_ section of this procedure. |
There was a problem hiding this comment.
This step might be better suited for the Deploying the Medical Diagnosis pattern section. E.g. say you can deploy the pattern either with the operator or with the command line
abhatt-rh
force-pushed
the
1193-modular
branch
from
77ff009 to
ff384ba
Compare
abhatt-rh
force-pushed
the
1193-modular
branch
2 times, most recently
from
7d652e3 to
2b603df
Compare
abhatt-rh
force-pushed
the
1193-modular
branch
from
2b603df to
d14ae64
Compare
|
Not merging this yet since I have a discussion open to understand why the htmltest fails for files that are renamed |
|
@abhatt-rh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/TELCODOCS-1193
Preview: https://310.docs-pr.acksyn.org/patterns/medical-diagnosis/