Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Publish to NPM with provenance #2276

Merged
merged 2 commits into from
Apr 27, 2024
Merged

chore: Publish to NPM with provenance #2276

merged 2 commits into from
Apr 27, 2024

Conversation

meyfa
Copy link
Contributor

@meyfa meyfa commented Aug 26, 2023

chore: Publish to NPM with provenance

The release process in this repository is already automated via GitHub Actions, which is a great first step toward creating trust in the supply chain. Recently, NPM has started to support publishing with the --provenance flag. This flag creates a link between the GitHub Actions run that created the release and the final artifact on NPM. This linkage further ensures that package installs can be traced back to a specific code revision.

For more information on publishing with provenance, please refer to: https://github.blog/2023-04-19-introducing-npm-package-provenance/

Note that the update of Node.js to v18 is required for NPM v9.5+ to be installed, which is needed for provenance.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.

For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b958bd7) 99.95% compared to head (2512316) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2276   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2454     2454           
  Branches      619      619           
=======================================
  Hits         2453     2453           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set up anything different than now? Like refreshing the NPM token with different permissions. Or is it all set up, ready to go already since we publish to NPM?

@meyfa
Copy link
Contributor Author

meyfa commented Aug 26, 2023

@WikiRik This is all that's needed. NPM and GitHub Actions handles the rest automatically.

@meyfa
Copy link
Contributor Author

meyfa commented Aug 26, 2023

@profnandaa profnandaa merged commit 2253a77 into validatorjs:master Apr 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants