Skip to content

Conversation

jbrinkman
Copy link
Collaborator

@jbrinkman jbrinkman commented Aug 8, 2025

Adds a GitHub Actions workflow to compare Valkey.Glide vs StackExchange.Redis using dotnet-api-diff.

  • Installs dotnet-api-diff via curl-based script
  • Uses config at .github/api-compat/api-diff-config.json (namespace/type mappings, breaking-change rules)
  • Builds and compares net8.0 only
  • Emits clean HTML report and uploads as artifact
  • Fails on breaking changes
image

@jbrinkman jbrinkman requested a review from a team as a code owner August 8, 2025 14:10
@jbrinkman jbrinkman force-pushed the jbrinkman/api-compat-workflow branch from e88c7ab to 4b65f4c Compare August 8, 2025 15:33
@jbrinkman jbrinkman force-pushed the jbrinkman/api-compat-workflow branch 3 times, most recently from 3149628 to 66bd90b Compare August 8, 2025 21:11
Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is weird with the PR description.

Do you mind attaching a report example there?

…put HTML; target net8.0 only

Signed-off-by: jbrinkman joe.brinkman@improving.com
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman joe.brinkman@improving.com
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman joe.brinkman@improving.com
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…SER DLL path; use nuget install

Signed-off-by: jbrinkman joe.brinkman@improving.com
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman joe.brinkman@improving.com
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…ompatibility workflow

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…ror handling

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
This reverts commit 1f5ee51.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
@jbrinkman jbrinkman force-pushed the jbrinkman/api-compat-workflow branch from 79629bd to 5a8515b Compare August 11, 2025 17:05
@jbrinkman jbrinkman merged commit dee8483 into main Aug 11, 2025
12 checks passed
@jbrinkman jbrinkman deleted the jbrinkman/api-compat-workflow branch August 11, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants