Skip to content

C#: Set Commands (GA) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2025
Merged

C#: Set Commands (GA) #9

merged 4 commits into from
Aug 6, 2025

Conversation

edlng
Copy link
Collaborator

@edlng edlng commented Aug 1, 2025

Adding the rest of Set commands for the GA release.

Issue link

This Pull Request is linked to issue (URL): #5

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@edlng
moving pr to new repo
9ec0bbe 
Signed-off-by: Edward Liang <edward.liang@improving.com>
@edlng edlng requested a review from a team as a code owner August 1, 2025 17:08
Yury-Fridlyand
Yury-Fridlyand approved these changes Aug 1, 2025
View reviewed changes
Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to merge #8 first, to get CI run on your PR

yipin-chen
yipin-chen approved these changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approve after addressing review comment and CI error.

jbrinkman
jbrinkman approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix line endings and :shipit:

edlng and others added 2 commits August 6, 2025 12:53
@edlng
fix line breaks
f087c2b 
Signed-off-by: Edward Liang <edward.liang@improving.com>
@edlng
Merge branch 'main' into edlng-set-commands-ga
ae0df7a
@edlng edlng merged commit 3c4240a into main Aug 6, 2025
10 checks passed
@edlng edlng deleted the edlng-set-commands-ga branch August 6, 2025 20:09
This was referenced Jul 31, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrinkman jbrinkman jbrinkman approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

+1 more reviewer

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edlng @jbrinkman @Yury-Fridlyand @yipin-chen