Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CodeQL configuration #2186

Merged

Conversation

jamesx-improving
Copy link
Collaborator

This CodeQL configuration is primarily a default configuration generated by github, which enabled security check for all languages, including Java-Kotlin, python, node-js, go and c#. The only change made is to exclude the examples directory for CodeQL through an external configuration file .github/codeql/codeql-config.yml.

@jamesx-improving jamesx-improving requested a review from a team as a code owner August 22, 2024 02:12
@Yury-Fridlyand Yury-Fridlyand added the CI/CD CI/CD related label Aug 22, 2024
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/codeql/codeql-config.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming comments are addressed

@jamesx-improving
Copy link
Collaborator Author

Comments addressed.

Still needs repo admin to turn on CodeQL Advanced mode to enable this configuration.

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/workflows/codeql.yml Show resolved Hide resolved
Comment on lines 5 to 7
branches: ["main"]
pull_request:
branches: ["main"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add following to branch lists please:

v.?[0-9]+.[0-9]+.[0-9]+
v.?[0-9]+.[0-9]+
v?[0-9]+.[0-9]+.[0-9]+
v?[0-9]+.[0-9]+

Signed-off-by: James Xin <james.xin@improving.com>
@jamesx-improving jamesx-improving merged commit 28813a9 into valkey-io:main Sep 9, 2024
8 checks passed
janhavigupta007 pushed a commit to janhavigupta007/glide-for-redis that referenced this pull request Sep 11, 2024
* add CodeQL configuration

---------

Signed-off-by: James Xin <james.xin@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants