Blog post about new hash table #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainsupreme
reviewed
Jan 16, 2025
rainsupreme
reviewed
Jan 16, 2025
madolson
reviewed
Feb 26, 2025
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
force-pushed
the
hashtable-blog-post
branch
from
7741e22 to
fccd669
Compare
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
changed the title
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
|
@rjd15372 Do you want to take a look? |
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
rjd15372
reviewed
Mar 28, 2025
Comment on lines
206
to
207
| better. The zigzag pattern is because of aliasing between the datapoint spacing | ||
| and the memory allocator's discrete allocation sizes. |
There was a problem hiding this comment.
"The zigzag pattern is because of aliasing between the datapoint spacing
and the memory allocator's discrete allocation sizes."
I couldn't understand what you mean with this. Can you describe it in another way to make it more clear?
There was a problem hiding this comment.
I took this from Rain's issue with the diagrams. :)
It's wasted memory when jemalloc allocates more memory than we need. The sizes are as in this table: http://jemalloc.net/jemalloc.3.html#size_classes
Explaining this is probably not worth it. I'll cut it down to this, ok?
The zigzag pattern is because of unused memory resulting from the memory
allocator's discrete allocation sizes.
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
madolson
reviewed
Mar 28, 2025
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
zuiderkwast
added a commit
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new new hash table is one of the highlights of the upcoming 8.1 release.