Skip to content

Commit 27cb1a2

Browse files
IlyaSurmayvalorkin
authored andcommitted
fix(progressbar): fix bs4, animation, add striped option, remove bs4 demos (#3500)
* fix(progressbar): fix empty bs4 bar, add striped option, remove unnecessary DOM nesting * fix(progressbar): fix animation, remove ProgressDirective, remove bs4 demos, simplify html
1 parent 7b43295 commit 27cb1a2

31 files changed

+126
-352
lines changed

demo/src/app/components/+progressbar/demos/bs3/static/static.html

Lines changed: 0 additions & 11 deletions
This file was deleted.

demo/src/app/components/+progressbar/demos/bs4/dynamic/dynamic.html

Lines changed: 0 additions & 13 deletions
This file was deleted.

demo/src/app/components/+progressbar/demos/bs4/dynamic/dynamic.ts

Lines changed: 0 additions & 35 deletions
This file was deleted.

demo/src/app/components/+progressbar/demos/bs4/stacked/stacked.html

Lines changed: 0 additions & 7 deletions
This file was deleted.

demo/src/app/components/+progressbar/demos/bs4/stacked/stacked.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

demo/src/app/components/+progressbar/demos/bs4/static/static.html

Lines changed: 0 additions & 11 deletions
This file was deleted.

demo/src/app/components/+progressbar/demos/bs4/static/static.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

demo/src/app/components/+progressbar/demos/bs3/config/config.ts renamed to demo/src/app/components/+progressbar/demos/config/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ProgressbarConfig } from 'ngx-bootstrap/progressbar';
44
// such override allows to keep some initial values
55

66
export function getProgressbarConfig(): ProgressbarConfig {
7-
return Object.assign(new ProgressbarConfig(), { animate: false, max: 150 });
7+
return Object.assign(new ProgressbarConfig(), { animate: true, striped: true, max: 150 });
88
}
99

1010
@Component({

demo/src/app/components/+progressbar/demos/bs3/dynamic/dynamic.html renamed to demo/src/app/components/+progressbar/demos/dynamic/dynamic.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
<progressbar [animate]="false" [value]="dynamic" type="success"><b>{{dynamic}}%</b></progressbar>
77

88
<small><em>Object (changes type based on value)</em></small>
9-
<progressbar class="progress-striped active" [value]="dynamic" [type]="type">
10-
{{type}} <i *ngIf="showWarning">!!!Watch out !!!</i>
11-
</progressbar>
9+
<progressbar class="progress-striped active" [value]="dynamic" [type]="type">{{type}}</progressbar>
1210

1311
<button type="button" class="btn btn-sm btn-primary" (click)="random()">Randomize</button>

0 commit comments

Comments
 (0)