Skip to content

Commit 69bd6fa

Browse files
authored
fix(datepicker): reactive forms in onpush components (#2947)
1 parent 5662e20 commit 69bd6fa

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/datepicker/bs-datepicker-input.directive.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {
2+
ChangeDetectorRef,
23
Directive, ElementRef, forwardRef, Host, OnInit, Renderer2
34
} from '@angular/core';
45
import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';
@@ -29,7 +30,9 @@ export class BsDatepickerInputDirective
2930

3031
constructor(@Host() private _picker: BsDatepickerComponent,
3132
private _renderer: Renderer2,
32-
private _elRef: ElementRef) {
33+
34+
private _elRef: ElementRef,
35+
private changeDetection: ChangeDetectorRef) {
3336
this._picker.bsValueChange.subscribe((v: Date) => this._setInputValue(v));
3437
}
3538

@@ -41,6 +44,7 @@ export class BsDatepickerInputDirective
4144
) || '';
4245
this._renderer.setProperty(this._elRef.nativeElement, 'value', initialDate);
4346
this._onChange(v);
47+
this.changeDetection.markForCheck();
4448
}
4549

4650
onChange(event: any) {

src/datepicker/bs-daterangepicker-input.directive.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Directive, ElementRef, forwardRef, Host, OnInit, Renderer2 } from '@angular/core';
1+
import { ChangeDetectorRef, Directive, ElementRef, forwardRef, Host, OnInit, Renderer2 } from '@angular/core';
22
import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';
33
import { formatDate } from '../bs-moment/format';
44
import { getLocale } from '../bs-moment/locale/locales.service';
@@ -27,7 +27,8 @@ export class BsDaterangepickerInputDirective
2727

2828
constructor(@Host() private _picker: BsDaterangepickerComponent,
2929
private _renderer: Renderer2,
30-
private _elRef: ElementRef) {
30+
private _elRef: ElementRef,
31+
private changeDetection: ChangeDetectorRef) {
3132
this._picker.bsValueChange.subscribe((v: Date[]) => this._setInputValue(v));
3233
}
3334

@@ -48,6 +49,7 @@ export class BsDaterangepickerInputDirective
4849
}
4950
this._renderer.setProperty(this._elRef.nativeElement, 'value', range);
5051
this._onChange(date);
52+
this.changeDetection.markForCheck();
5153
}
5254

5355
onChange(event: any) {

0 commit comments

Comments
 (0)