Implement issue https://github.com/vanadiumlabs/arbotix_ros/issues/24: #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow 16 bit values on arbotix_msgs/Analog messages, but assume 8 bits by default
| @@ -128,7 +128,8 @@ class ArbotixROS(ArbotiX): | |||
| pin = rospy.get_param('~'+v+'/'+name+'/pin',1) | |||
| value = rospy.get_param('~'+v+'/'+name+'/value',0) | |||
| rate = rospy.get_param('~'+v+'/'+name+'/rate',10) | |||
| self.io[name] = t(name, pin, value, rate, self) | |||
| leng = rospy.get_param('~'+v+'/'+name+'/leng',1) # just for analog sensors | |||
There was a problem hiding this comment.
Parameter names are rarely shortened, so this should really be spelled out fully as "length". (the name on the server that is, not the python variable name)
|
👍 |
|
Any problem with the PR? Should I change something else? |
|
Nope. I just forgot to come back and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow 16 bit values on arbotix_msgs/Analog messages, but assume 8 bits by default. So changes should be transparent for current users except for the extra size of message value.