Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any problem on providing 16 bit values on arbotix_msgs/Analog messages? #24

Closed
corot opened this issue Aug 17, 2014 · 1 comment
Closed

Is there any problem on providing 16 bit values on arbotix_msgs/Analog messages? #24

corot opened this issue Aug 17, 2014 · 1 comment

Comments

@corot
Copy link
Contributor

corot commented Aug 17, 2014

I use arbotix_ros with an OpenCM9.04 Dinamixel board, that provides analog readings between 0 and ~2000. Instead of converting to 0..255, could we just change the message? I suppose this will have no impact on current use with ArbotiX boards.
@mikeferguson
Copy link
Member

Other than the MD5 breakage, I see no issues here. It's really too late to break the hydro messages, but I think we could merge a PR for indigo.

corot added a commit to corot/arbotix_ros that referenced this issue Aug 17, 2014
@corot
Implement issue vanadiumlabs#24:
09c7cd6 
Allow 16 bit values on arbotix_msgs/Analog messages, but assume 8 bits
by default
corot added a commit to corot/thorp that referenced this issue Aug 17, 2014
@corot
Allow reading 2-byte analog inputs:
b27b024 
vanadiumlabs/arbotix_ros#24.

I have also implemented temptatively digital read, just to avoid the
stucked arbotix_driver, but 99% it is wrong.
mikeferguson added a commit that referenced this issue Aug 21, 2014
@mikeferguson
Merge pull request #25 from corot/indigo-devel
4b67379 
Implement issue #24:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corot @mikeferguson