Update modules mvids before rewriting an assembly #16
Conversation
| @@ -122,6 +122,9 @@ public IAssemblyLoader Rewrite(string path) | |||
| WriteSymbols = hasSymbols | |||
| }; | |||
|
|
|||
| foreach (var module in assembly.Modules) | |||
| module.Mvid = Guid.NewGuid(); | |||
There was a problem hiding this comment.
For consistency, please fix the indenting to match the current code base convention of 4 spaces. Also, I prefer to use curly braces (each on a new line) for every for each body, including the single line ones.
|
Thanks for the pull request! The mvid (module version id) is something that I wasn't aware of and seems quite interesting. It might also be related to #1. I will do some testing shortly. |
Update modules mvids before rewriting an assembly
|
@ESolovova Thank you so much for the looking into this. @vanderkleij Your library is awesome. This will help our company getting coverage for lots of legacy code. |
|
Thanks for the kind words! Glad you like it 👍 Version 0.5.25 that includes this fix is available on nuget now. |
|
@vanderkleij Thank you. I reported an issue we ran into when using with NUnit. Currently, I'm building locally to get around it. |
When we modify an assembly we should also update its mvid. Otherwise some coverage/profiling tools can be confused by having different assemblies with similar mvids. Please see, for instance: https://dotnettools-support.jetbrains.com/hc/en-us/community/posts/205988489-Unit-Testing-works-but-dotCover-failes-to-run-test-Unrecoverable-Error