-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Astro integration page #1283
docs: add Astro integration page #1283
Conversation
|
--- | ||
|
||
<button class={button}>Click Me!</button> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows up as unstyled for me. 😬
I took a peek at the CompiledCode
and SyntaxHighlighter
system but didn't want to make too many changes. I was scared. What would you all advise be done here?
FWIW the progress I made was trying to import and register the markup
syntax highlighting language for Astro, but that didn't get all the way:
// @ts-ignore
import markup from 'react-syntax-highlighter/dist/esm/languages/prism/markup';
SyntaxHighlighter.registerLanguage('astro', markup);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a bit of digging, it looks like it will take a lot of work to have syntax highlighting for Astro files. Given it's only used on this page, I think we're ok with not having it.
Thanks for the props @JoshuaKGoldberg, much appreciated ser! 🙏 |
```tsx | ||
// Button.astro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JoshuaKGoldberg! |
Adds an Astro page per discussion in #678 (comment) -> #1266.
@bejzik8 answered flawlessly so this shamelessly steals that explanation 😄. Hence the co-author attribute below.
Co-authored-by: Mirko Basic bejzik8@gmail.com