Code review for ts-rewrite

[vincekovacs]

Some modification:

• Code reformat
  • indent code 4 spaces
  • change import order to alphabetical
  • fix tslint errors
• Remove TS type from types directory (TypeScript will autogenerate type definitions into dist folder)
• Specific type constraint
• Make verify method generic

[coveralls]

Coverage remained the same at 100.0% when pulling 1ed1990 on review into ee5ed68 on master.

[coveralls]

Coverage remained the same at 100.0% when pulling 353afcb on review into ee5ed68 on master.

[coveralls]

Coverage remained the same at 100.0% when pulling b7607e7 on review into ee5ed68 on master.

[gyszalai]

2017. aug. 10. dátummal, 9:36 időpontban Kovács Vince <notifications@github.com> írta:

…

Some modification (code reformat, restructure). See commit messages for more information. You can view, comment on, or merge this pull request online at: #2 Commit Summary Code reformat (indent code 4 spaces, reorganise import order) Remove unused bluebird import Remove unnecessary TS type (definitions are autogenerated by TS inside dist folder) Use more specific type constraints for stronger type checks Some code refactor (throw error at end of extractKeyId method instead in try-catch block) File Changes M index.ts (2) M src/JwtHandler.spec.ts (313) M src/JwtHandler.ts (160) M src/MissingKeyIdError.spec.ts (35) M src/MissingKeyIdError.ts (12) M src/UnknownKeyIdError.spec.ts (41) M src/UnknownKeyIdError.ts (24) D types/index.d.ts (25) Patch Links: https://github.com/vanioinformatika/node-jwt-wrapper/pull/2.patch https://github.com/vanioinformatika/node-jwt-wrapper/pull/2.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[coveralls]

Coverage decreased (-2.0%) to 98.02% when pulling df06366 on review into ee5ed68 on master.

[coveralls]

Coverage decreased (-2.0%) to 98.02% when pulling 76c1f22 on review into ee5ed68 on master.

[coveralls]

Coverage decreased (-2.0%) to 98.02% when pulling ef21cd0 on review into ee5ed68 on master.