-
-
Notifications
You must be signed in to change notification settings - Fork 336
Update Testing documentation #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Testing documentation #1054
Conversation
5d929d7
to
e0f2bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but not sure if we want to replace the XCT docs, or add a new one for Swift Testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @MahdiBM - we should keep the old XCTVapor docs but put a warning telling people they should choose VaporTesting unless they have a reason not to
I understand. In my opinion we should be promoting the Swift Testing option first and then add a note about the XCTest framework. I think that having a complete example with the new framework can be another way of encouraging its usage. What do you prefer? Maintain the XCTest with a note about Swift Testing or the other way around? |
Swift Testing first, XCTest at the bottom |
c131203
to
b8652c5
Compare
b8652c5
to
942f287
Compare
11901be
to
74128ea
Compare
@alemohamad you still need to call it to shutdown services, but if you use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@0xTim sorry, tapped on cancel the auto-merge. |
Following the issues #1038 and #594, this proposal suggests updating the Testing documentation to include Swift Testing as an alternative to XCTest.