Skip to content

Use default port for URLs #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Use default port for URLs #183

merged 1 commit into from
Apr 23, 2020

Conversation

vknabel
Copy link
Contributor

@vknabel vknabel commented Apr 23, 2020 •
edited by tanner0101
Loading

Adds support for database urls not containing an explicit port: postgres://user:password@localhost/database (#183).

@tanner0101 tanner0101 added enhancement New feature or request semver-patch Internal changes only labels Apr 23, 2020
@tanner0101 tanner0101 changed the title Use Postgres default port for URLs Use default port for URLs Apr 23, 2020
tanner0101
tanner0101 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tanner0101 tanner0101 merged commit b465e9e into vapor:master Apr 23, 2020
@tanner0101
Copy link
Member

These changes are now available in 2.0.0-rc.1.2

@vknabel
Copy link
Contributor Author

vknabel commented Apr 23, 2020

Thank you very much for the fast and good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vknabel @tanner0101