Skip to content

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Oct 19, 2022

Haven't yet built a working reusable workflow that would allow centralizing this for packages which require supporting services (such as a database server).

@gwynne gwynne requested a review from 0xTim October 19, 2022 23:17
@gwynne gwynne self-assigned this Oct 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #233 (e0152d9) into main (923e758) will increase coverage by 0.47%.
The diff coverage is 53.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   22.51%   22.98%   +0.47%     
==========================================
  Files          10       10              
  Lines         733      744      +11     
==========================================
+ Hits          165      171       +6     
- Misses        568      573       +5     
Flag Coverage Δ
unittests 22.98% <53.84%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresKit/PostgresConfiguration.swift 17.24% <ø> (+1.72%) ⬆️
Sources/PostgresKit/PostgresDialect.swift 57.40% <0.00%> (-7.18%) ⬇️
Sources/PostgresKit/PostgresConnectionSource.swift 50.70% <100.00%> (+3.73%) ⬆️

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm assuming there are no major changes between 11-15 that would necessitate us testing individual features (and even if there are we should probably push that into PostgresNIO)

@gwynne
Copy link
Member Author

gwynne commented Oct 20, 2022

Nope, at least nothing that PostgresKit cares about - that's all PostgresNIO's concern, and even then the only real wire protocol change since 11 that I can think of offhand was the addition of streaming result rows.

@gwynne gwynne merged commit df9146a into main Oct 20, 2022
@gwynne gwynne deleted the update-ci branch October 20, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants