Skip to content

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Nov 22, 2021

Use TSan (matching the workflow for pushes to main) with the unit tests, actually invoke brew correctly for the macOS tests.

@gwynne gwynne added bug Something isn't working no-release-needed labels Nov 22, 2021
@gwynne gwynne requested a review from 0xTim November 22, 2021 10:17
@gwynne gwynne self-assigned this Nov 22, 2021
@gwynne
Copy link
Member Author

gwynne commented Nov 22, 2021

Test failures are expected until vapor/fluent-postgres-driver#186 is merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #200 (8f39b3d) into fix-decimal (aba2e3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           fix-decimal     #200   +/-   ##
============================================
  Coverage        41.84%   41.84%           
============================================
  Files              116      116           
  Lines             7779     7779           
============================================
  Hits              3255     3255           
  Misses            4524     4524           
Flag Coverage Δ
unittests 41.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba2e3a...8f39b3d. Read the comment docs.

@gwynne gwynne merged commit c113812 into fix-decimal Nov 22, 2021
@gwynne gwynne deleted the more-ci-oopsies branch November 22, 2021 12:14
@gwynne
Copy link
Member Author

gwynne commented Nov 22, 2021

Whoops. Somehow this PR got targeted to the fix-decimal branch rather than main.

@gwynne
Copy link
Member Author

gwynne commented Nov 22, 2021

Resolved by cherry-picking the squashed merge to main and force-pushing a revert of fix-decimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants