Skip to content

Ensure pool runs until all connections are closed #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2023
Merged

Ensure pool runs until all connections are closed #429

merged 1 commit into from
Oct 28, 2023

Conversation

fabianfett
Copy link
Collaborator

  • Ensure pool runs until all connections are closed
  • Fix an ordering issue in RequestQueue
  • Remove unused closeConnection in NewPoolActions.

@fabianfett fabianfett added the semver-patch No public API change. label Oct 28, 2023
@fabianfett fabianfett added this to the ConnectionPool milestone Oct 28, 2023
@fabianfett fabianfett requested a review from gwynne October 28, 2023 12:30
@codecov-commenter
Copy link

Codecov Report

Merging #429 (0c11d37) into main (468ae25) will decrease coverage by 0.02%.
The diff coverage is 95.45%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   60.72%   60.70%   -0.02%     
==========================================
  Files         121      121              
  Lines        9481     9489       +8     
==========================================
+ Hits         5757     5760       +3     
- Misses       3724     3729       +5
Files Coverage Δ
Sources/ConnectionPoolModule/ConnectionPool.swift 76.80% <100.00%> (+1.49%) ⬆️
...tionPoolModule/PoolStateMachine+RequestQueue.swift 100.00% <100.00%> (ø)
...ources/ConnectionPoolModule/PoolStateMachine.swift 79.20% <92.30%> (-2.17%) ⬇️

... and 3 files with indirect coverage changes

@fabianfett fabianfett enabled auto-merge (squash) October 28, 2023 13:21
@fabianfett fabianfett merged commit add68a0 into vapor:main Oct 28, 2023
@fabianfett fabianfett added the ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule semver-patch No public API change.
Projects
None yet
Milestone
ConnectionPool
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @codecov-commenter @gwynne