You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have started porting my changes to klogg.
I have one issue at the moment: https://github.com/gin-ahirsch/glogg/blob/4ac06ca0d198b0773f2ad81beace333d9695df02/src/logdata/src/logfiltereddata.cpp#L359
I've changed LogFilteredDataWorkerThread::getSearchResult() to LogFilteredDataWorkerThread::updateSearchResult(), which instead of copying the whole array only appends the missing elements. Since in glogg the array is updated linearily this is trivial. I assume that the multi-threaded search feature of klogg means that the updates can also happen out of order, so obviously that breaks.
I want to try and change LogFilteredDataWorkerThread to not sort the array at all and just append to the end, so LogFilteredData can do the sorting in its place, which will allow the update and indexing for the eager filteredItemsCache_ to work as I intended.
It's possible that I don't get the time to work on this until mid-April, so I wanted to drop this note here.
Consider merging some tweaks from @gin-ahirsch's fork https://github.com/gin-ahirsch/glogg
The text was updated successfully, but these errors were encountered: