Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to marks and matches cache #37

Closed
2 tasks
variar opened this issue Jun 16, 2018 · 3 comments
Closed
2 tasks

Tweaks to marks and matches cache #37

variar opened this issue Jun 16, 2018 · 3 comments
Assignees
Projects
Milestone

Comments

@variar
Copy link
Owner

variar commented Jun 16, 2018

Consider merging some tweaks from @gin-ahirsch's fork https://github.com/gin-ahirsch/glogg

@variar variar added this to the 2018.06 milestone Jun 16, 2018
@variar variar self-assigned this Jun 16, 2018
@variar variar added this to Todo in Perf via automation Jun 16, 2018
@variar variar moved this from Todo to Doing in Perf Jan 29, 2019
@variar variar modified the milestones: 2019.02, 2019.next Feb 2, 2019
@gin-ahirsch
Copy link

Note that the commit have been updated. It's best to follow this branch: https://github.com/gin-ahirsch/glogg/commits/eager-filtered-items-cache.

@gin-ahirsch
Copy link

I have started porting my changes to klogg.
I have one issue at the moment: https://github.com/gin-ahirsch/glogg/blob/4ac06ca0d198b0773f2ad81beace333d9695df02/src/logdata/src/logfiltereddata.cpp#L359
I've changed LogFilteredDataWorkerThread::getSearchResult() to LogFilteredDataWorkerThread::updateSearchResult(), which instead of copying the whole array only appends the missing elements. Since in glogg the array is updated linearily this is trivial. I assume that the multi-threaded search feature of klogg means that the updates can also happen out of order, so obviously that breaks.
I want to try and change LogFilteredDataWorkerThread to not sort the array at all and just append to the end, so LogFilteredData can do the sorting in its place, which will allow the update and indexing for the eager filteredItemsCache_ to work as I intended.

It's possible that I don't get the time to work on this until mid-April, so I wanted to drop this note here.

@gin-ahirsch
Copy link

The port is now complete and functional at https://github.com/gin-ahirsch/glogg/tree/eager-filtered-items-cache-klogg. I'll open a PR once #67 is merged, since the branch builds on those changes.

@variar variar closed this as completed Sep 3, 2019
Perf automation moved this from Doing to Done Sep 3, 2019
@variar variar modified the milestones: 2019.next, 2019.09 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Perf
  
Done
Development

No branches or pull requests

2 participants