Refactor LogFilteredData #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I've been to busy planing vacation. Will try to look through the code this week. |
That method was used solely to delete the last matched line so that it is not matched a second time if we update the search. This change instead modifies the UpdateSearchOperation::start() so that the line never gets matched twice in the first place.
Since we add a chunk of results, which is sorted in itself, we don't need to perform a full merge/sort algorithm. We just need to find the starting-place for the chunk and can insert it there without additional sorting.
|
I added two changes from my upcoming PR implementing #37. These stand on their own though, so I added them to this branch. |
2 tasks
variar
added a commit
that referenced
this pull request
Jun 26, 2019
variar
added a commit
that referenced
this pull request
Jun 26, 2019
|
I've merged core of PR in 58ed0e4 using QFlags to avoid manually write flag operations. I'd prefer include structure as it is now, this is like we do it in internal projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes of my eager-filteredItemsCache-branch which do not actually change the behavior of the cache. Thus the changes should be uncontroversial.
I'm unsure if
FilteredLineTypeshould be kept asenum classas the operator overloading, as well as no implicit cast tobool, add some noise. Maybe it should be changed back to a weaklier-typedenum.